Review Request 126131: Don't delete gl texture twice in thumbnail
Alex Merry
alex.merry at kde.org
Sun Nov 22 13:24:00 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review88691
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Nov. 22, 2015, 1:57 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126131/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2015, 1:57 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The QSGTextures are created with
>
> window()->createTextureFromId(m_texture, QSize(w,h),
> QuickWindow::TextureOwnsGLTexture));
>
> this means we don't want to be deleting textures ourselves too, it will
> be deleted when we delete the QSGTexture, which is a scoped pointer
> inside our QSGNode.
>
> BUG: 355644
> REVIEW:
>
>
> Diffs
> -----
>
> src/declarativeimports/core/windowthumbnail.cpp 2b09657e8ce6bd1cca1acc323d5955b2f1a1efb2
>
> Diff: https://git.reviewboard.kde.org/r/126131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151122/7590141a/attachment.html>
More information about the Plasma-devel
mailing list