Review Request 126127: [powerdevil] add missing initializations, minor string optimizations

Nick Shaforostoff shafff at ukr.net
Sat Nov 21 21:03:34 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126127/
-----------------------------------------------------------

(Updated Nov. 21, 2015, 9:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik and Xuetian Weng.


Changes
-------

Submitted with commit 5b0faeb67e02edb22bf79699c4ef2217f248a945 by Nick Shaforostoff to branch master.


Repository: powerdevil


Description
-------

This patch fixes member variable initialization related issues found by Coverity static analyzer.

Also there are few minor qstring-related optimizations, plus switching from qlist to qvector for storing ints (consumes less memory, doesn't affect speed)


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 
  daemon/backends/upower/xrandrxcbhelper.cpp 9a8f49e 
  daemon/kdedpowerdevil.cpp 6e92578 
  daemon/kwinkscreenhelpereffect.h 4d0a163 
  daemon/powerdevilaction.cpp 187f3fb 
  daemon/powerdevilbackendinterface.cpp 86d7f7e 
  daemon/powerdevilpolicyagent.cpp 6b46c9c 

Diff: https://git.reviewboard.kde.org/r/126127/diff/


Testing
-------

compiles fine


Thanks,

Nick Shaforostoff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151121/177262de/attachment.html>


More information about the Plasma-devel mailing list