Review Request 126126: kicker: always show arrows for items with children

Pino Toscano pino at kde.org
Sat Nov 21 16:09:58 UTC 2015



> On Nov. 21, 2015, 3:05 p.m., Eike Hein wrote:
> > This is intentional because in particular the root menu looks quite ugly and busy with all arrows ...
> 
> Pino Toscano wrote:
>     To me a menu with submenu entries not marked as such (if not when hovering them) is ugly, inconsistent with every other menu around, and lead me thinking "oh, there must be something wrong, no submenus?" when I looked at it at first.
>     
>     Can you please point me at discussions and/or design documents where this incoherency has been decided? Thanks.
> 
> Eike Hein wrote:
>     There's been no discussions and/or design documents about it, it was a decision by me when I implemented the menu. I'm open to a discussion about it; the VDG should chime in.
>     
>     
>     (However please drop the childish passive aggressive act, it's vile and antagonistic, and has no place in our discussion venues.)

> (However please drop the childish passive aggressive act, it's vile and antagonistic, and has no place in our discussion venues.)

I'm not sure what you refer to, since there was nothing of what you describe in my message: I described what my impressions with the new kicker. Also, considering nowadays most of the design decision pass through a VDG, I asked whether there was a decision of it about this "look" behaviour. That's it.

Back to the actual issue: I'm not sure why the VDG should chime in this situation, as from what I see the situation is pretty simple: every menu I see  - starting from application menus in different toolkits and different OSes - usually show arrows in any case for submenus, including previous versions of the menus (and I see kickoff in plasma 5.4 has the same issue...). Hence, as a matter of coherency, a menu should just display arrows, not just on hover.


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88672
-----------------------------------------------------------


On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/package/contents/ui/ItemListDelegate.qml becf13d278862b20f46eacae628364708abadfdc 
> 
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151121/1d76f6f1/attachment-0001.html>


More information about the Plasma-devel mailing list