Review Request 126113: make event filters static to decrease installed filters on qApp

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126113/#review88643
-----------------------------------------------------------

Ship it!



src/plasma/svg.cpp (line 590)
<https://git.reviewboard.kde.org/r/126113/#comment60763>

    we may as well remove this method then?


- David Edmundson


On Nov. 20, 2015, 12:19 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126113/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 12:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 351923
>     http://bugs.kde.org/show_bug.cgi?id=351923
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> since seems there are so many event filters installed on the QApplication installed that may give performance issues, try to use separate, singleton watchers for them to decrease the amount of eventfilters called
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.h fa2256e 
>   src/declarativeimports/core/units.cpp 4e2adae 
>   src/plasma/private/svg_p.h 597465e 
>   src/plasma/private/theme_p.h 5b8f71c 
>   src/plasma/private/theme_p.cpp f346343 
>   src/plasma/svg.cpp bcceaf7 
> 
> Diff: https://git.reviewboard.kde.org/r/126113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151120/43873b66/attachment.html>