Review Request 126104: Make networkmanager-qt an optional dependency

Marco Martin notmart at gmail.com
Thu Nov 19 10:16:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126104/#review88581
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Nov. 18, 2015, 3:55 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126104/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 3:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I can't compile networkmanager-qt on my current system because the version
> of NetworkManager seems to be too old.
> 
> Also not every system has NetworkManager (FreeBSD?) so it should be
> optional.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d21a2b7a7774ac712f905f1db1ee478dca10b45c 
>   dataengines/CMakeLists.txt 014da10aac5629be202bd5ad96012f817bf846ef 
> 
> Diff: https://git.reviewboard.kde.org/r/126104/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151119/2c2c8334/attachment-0001.html>


More information about the Plasma-devel mailing list