Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

Martin Gräßlin mgraesslin at kde.org
Thu Nov 19 07:27:18 UTC 2015



> On Nov. 19, 2015, 8:22 a.m., Thomas Lübking wrote:
> > Is the full path required because of security concerns or because startplasmacompositor is broken (lacks proper environment setup)?

security concerns. Problem is that an env scripct (which are sourced for reasons by the login process):
alias kwin_wayland=kwin_evil_wayland

and the kwin_evil_wayland could do things like key logging.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88567
-----------------------------------------------------------


On Nov. 19, 2015, 7:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:44 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -----
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> -------
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151119/f2c536cd/attachment-0001.html>


More information about the Plasma-devel mailing list