Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

Martin Gräßlin mgraesslin at kde.org
Thu Nov 19 06:56:09 UTC 2015



> On Nov. 19, 2015, 7:53 a.m., Bhushan Shah wrote:
> > Is it posssible to put it in seperate file? Because CMakeConfig is named as DBusInterface and no-one would expect it to have path to kwin_wayland.

well I used what we have. I'm open with introducing a new file or renaming after Plasma 5.5. release, but at the moment adding a new file here and changing in Plasma-workspace would technically be a new dependency after feature freeze.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126106/#review88563
-----------------------------------------------------------


On Nov. 19, 2015, 7:44 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126106/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:44 a.m.)
> 
> 
> Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> The absolute path is needed by e.g. startplasmacompositor.
> 
> 
> Diffs
> -----
> 
>   KWinDBusInterfaceConfig.cmake.in 89a69032c27966c54dc40536355b35eb4692e426 
> 
> Diff: https://git.reviewboard.kde.org/r/126106/diff/
> 
> 
> Testing
> -------
> 
> installs with correct path
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151119/6a62c9f5/attachment.html>


More information about the Plasma-devel mailing list