Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

Gregor Mi codestruct at posteo.org
Thu Nov 19 05:39:04 UTC 2015



> On Nov. 18, 2015, 11:28 p.m., David Edmundson wrote:
> > Sorry, was there an extra discussion that's not mentioned on here?

Hi David, the original requirement was to ask the VDG team and follow their decision (as you said 3 month ago). The comment "Nevertheless, we agreed that since greying out is definitely not the correct visualization and your patch fixes this, you can ship it." from Thomas on Oct. 27 reads like a "Ship It" from the designers to me.


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review88552
-----------------------------------------------------------


On Nov. 18, 2015, 10:51 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 10:51 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jens Reuterberg.
> 
> 
> Bugs: 311991
>     https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I am not aware of.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151119/952ad426/attachment.html>


More information about the Plasma-devel mailing list