Review Request 125862: Add simple calendar events plugin based on KHolidays

[Kai Uwe Broulik]

> On Nov. 18, 2015, 9:14 vorm., Kai Uwe Broulik wrote:
> > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37
> > <https://git.reviewboard.kde.org/r/125862/diff/2/?file=417230#file417230line37>
> >
> >     Add context this
> 
> Martin Klapetek wrote:
>     Isn't "this" caputred implicitly?
> 
> David Edmundson wrote:
>     no, but it is captured by "="
>     If it wasn't you'd have had a compile error.
> 
> Martin Klapetek wrote:
>     Right, that's what I meant, "implicitly if you use [=]"
>     
>     Thinking about it, capturing [this] instead of [=] might
>     make more sense as a tinytinyoptimization as the lambda
>     does require only [this] in fact.

I was referring to connect(this, &Foo::bar, this, [=] { ... }) but given you connect *from* this already, I suppose there's no need to provide a receiver context. Sorry for the noise.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review88512
-----------------------------------------------------------


On Nov. 18, 2015, 12:33 vorm., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 12:33 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4783a78 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
>   plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp PRE-CREATION 
>   plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> -------
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151118/3cd877d0/attachment-0001.html>