Review Request 126018: Use the plural form for "Notification" category
Martin Klapetek
martin.klapetek at gmail.com
Wed Nov 18 17:19:54 UTC 2015
> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote:
> > > should I change also X-KDE-System-Settings-Category=notification to notifications
> >
> > I don't think so, it would require changing everywhere. Unless there is nothing actually using it, in which case, yes.
>
> Luigi Toscano wrote:
> Where should I look for its usage? But anyway, if you think it shouldn't matter, I will commit (just on time before the freeze, I missed the "ship it")
lxr.kde.org probably.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126018/#review88227
-----------------------------------------------------------
On Nov. 17, 2015, 12:51 a.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126018/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 12:51 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: systemsettings
>
>
> Description
> -------
>
> The word used to be plural (even if combined with other words) in the previous major version of Plasma.
>
> Question: if accepted, should I change also X-KDE-System-Settings-Category=notification to notifications, or would it be not worth of?
>
>
> Diffs
> -----
>
> categories/settings-personalization-notification.desktop 24fee0d
>
> Diff: https://git.reviewboard.kde.org/r/126018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luigi Toscano
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151118/e632e7a5/attachment.html>
More information about the Plasma-devel
mailing list