Review Request 126089: Metadata and color edit for plasma theme explorer

[Marco Martin]

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, line 97
> > <https://git.reviewboard.kde.org/r/126089/diff/1/?file=417103#file417103line97>
> >
> >     I think if you made the ColumnLayout the contentItem the Dialog would deduce window sizing automatically from it

does a white background if i assign as contentItem
if i assign it instead as default property, it deduces correctly the window size from ColumnLayout hints, but resizing the column layout from the manually resized window won't work


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, lines 189-192
> > <https://git.reviewboard.kde.org/r/126089/diff/1/?file=417103#file417103line189>
> >
> >     You could just make the GridLayout child of the ScrollView

I need to center it horizontally, i don't think it can do that if i don't put it in a blank parent?


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/MetadataEditor.qml, line 39
> > <https://git.reviewboard.kde.org/r/126089/diff/1/?file=417105#file417105line39>
> >
> >     .forceActiveFocus() ?

works this way too (iirc forceActiveFocus had problems with accessibility?)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
-----------------------------------------------------------


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> -------
> 
> * add a metadata editor functionality that allows to create a theme based upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -----
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> snapshot18.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151118/eee28a1f/attachment.html>