Review Request 125862: Add simple calendar events plugin based on KHolidays

Martin Klapetek martin.klapetek at gmail.com
Wed Nov 18 00:33:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/
-----------------------------------------------------------

(Updated Nov. 18, 2015, 1:33 a.m.)


Review request for Plasma.


Changes
-------

Changes
 * Add a config page
 * Multiple holiday regions now allowed
 * I didn't do the QScopedPointer thing cause now there are multiple regions and it doesn't bring anything for new-qDeleteAll pairs.


Repository: plasma-workspace


Description
-------

This is very simple for now as there is no configuration
yet, so it just takes the default region (your locale)
and shows holidays from that.

Obviously this needs a config to set up which regions
you want to show in there, but this is a start.


Diffs (updated)
-----

  CMakeLists.txt 4783a78 
  plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
  plasmacalendarintegration/HolidaysConfig.qml PRE-CREATION 
  plasmacalendarintegration/holidayeventsplugin.json PRE-CREATION 
  plasmacalendarintegration/holidaysevents.h PRE-CREATION 
  plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
  plasmacalendarintegration/qmlhelper/CMakeLists.txt PRE-CREATION 
  plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.h PRE-CREATION 
  plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp PRE-CREATION 
  plasmacalendarintegration/qmlhelper/qmldir PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125862/diff/


Testing
-------

Holidays are properly listed in calendar applet.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151118/93dc1abe/attachment.html>


More information about the Plasma-devel mailing list