Review Request 126096: Fix memory leak in kscreen backend of libkscreen
Martin Gräßlin
mgraesslin at kde.org
Tue Nov 17 16:08:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126096/#review88491
-----------------------------------------------------------
backends/xrandr/xrandrscreen.cpp (line 66)
<https://git.reviewboard.kde.org/r/126096/#comment60628>
Suggestion QScopedPointer<xcb_blah, QScopedPointerPodDeleter>
- Martin Gräßlin
On Nov. 17, 2015, 4:26 p.m., Lamarque Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126096/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 4:26 p.m.)
>
>
> Review request for Plasma, Solid and Daniel Vrátil.
>
>
> Repository: libkscreen
>
>
> Description
> -------
>
> libkscreen needs to free memory of xcb_randr_get_screen_resources_reply.
>
>
> Diffs
> -----
>
> backends/xrandr/xrandrscreen.cpp 8df957e
>
> Diff: https://git.reviewboard.kde.org/r/126096/diff/
>
>
> Testing
> -------
>
> No memory leak and everything still works.
>
>
> Thanks,
>
> Lamarque Souza
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151117/09778d47/attachment.html>
More information about the Plasma-devel
mailing list