Review Request 126097: [server] Fix possible crash after deleting an output(device)interface

Martin Gräßlin mgraesslin at kde.org
Tue Nov 17 15:37:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126097/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 3:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Sebastian Kügler.


Changes
-------

Submitted with commit 24c9f4576c2b63387ce63f6ecc7bd4a69aed527e by Martin Gräßlin to branch master.


Repository: kwayland


Description
-------

After deleting an OutputInterface the resources are not necessarily
destroyed, so unbind might still be called. The existing code just
casted the resource's user data which could then point to invalidated
memory.

This change verifies that we still have a Private* for the resource.
If not, it doesn't have to do any cleanup anyway.


Diffs
-----

  src/server/output_interface.cpp 646eb50bf816ce678ae5d726a993323c6fcbefa7 
  src/server/outputdevice_interface.cpp a2d0c43830e4d889c611dec76e11503891725c0b 

Diff: https://git.reviewboard.kde.org/r/126097/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151117/30a9b23b/attachment.html>


More information about the Plasma-devel mailing list