Review Request 126013: fix: kacess should not be built if xkb is not present

[Sebastian Kügler]

On Monday, November 16, 2015 04:16:26 PM Johan Ouwerkerk wrote:
> > Are we just disabling it and then be done?
> 
> That is not what this change is about. The change rectifies an inconsistency
> between the top level cmake configure stuff which checks the build
> environment for dependencies, and the C++ code which uses these
> unconditionally (e.g. kaccess).
> 
> The plasma-desktop build process deals with two classes of X11 deps:
> mandatory and optional. As it happens the XKB dep is classified optional in
> the top level cmake files, meaning configure will accept a build
> environment without XKB. This change makes sure that the 'optional' part
> is, indeed, consistently optional and does not result in build failure
> later (during make).
> 
> People who need kaccess must necessarily install the XKB headers/development
> files anyway. If the XKB dep is found then kacess is still included in the
> build and nothing changes (effectively).
> 
> (The alternative is to classify XKB as mandatory.)

Ah, ok. Thanks for the clarification.
-- 
sebas

http://www.kde.org | http://vizZzion.org