Review Request 126093: kcm_fonts: Don't touch any Xft options when anti-aliasing is set to system settings

Sebastian Kügler sebas at kde.org
Tue Nov 17 12:52:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126093/#review88475
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 17, 2015, 9:52 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126093/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 9:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> When anti-aliasing is set to system settings, fonts kcm still saves XftHintStyle and XftSubPixel which gets applied by krdb, resulting in overwriting any externally-set values (eg. from ~/.Xresources).
> 
> 
> Diffs
> -----
> 
>   kcms/fonts/fonts.cpp 167fd14 
> 
> Diff: https://git.reviewboard.kde.org/r/126093/diff/
> 
> 
> Testing
> -------
> 
> No Xft* is written to kdeglobal if anti-aliasing == system settings + it still gets correctly saved when anti-aliasing is set.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151117/4863cb69/attachment.html>


More information about the Plasma-devel mailing list