Review Request 126010: [digital-clock] Split the Calendar config stuff to it's own category + load the plugins configs
Martin Klapetek
martin.klapetek at gmail.com
Mon Nov 16 21:03:46 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126010/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 4b631f8c5c99957313ce2a1953b7975836fcef46 by Martin Klapetek to branch master.
Repository: plasma-workspace
Description
-------
Two commits.
Creates separate category for Calendar config, currently
only with "Show week numbers" and a list of calendar
plugins to enable/disable.
It's using groupbox but I think the groupbox looks weird
in the breeze theme, see screenshot.
---
Adds config categories from the loaded calendar plugin
configs. Needs https://git.reviewboard.kde.org/r/125966/
Diffs
-----
applets/digital-clock/package/contents/config/config.qml 877e40c
applets/digital-clock/package/contents/config/main.xml aacbe27
applets/digital-clock/package/contents/ui/configAppearance.qml fc9a09e
applets/digital-clock/package/contents/ui/configCalendar.qml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126010/diff/
Testing
-------
Applet settings lists all available plugins, enabling/disabling
them dynamically un/loads the plugins. Config window also contains
all plugins configs.
For some reason QML cuts off last letters from Labels, dunno why.
File Attachments
----------------
Calendar config page
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/09/52e2e536-4e98-4272-8a48-1d4fafc17548__snapshot41.png
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/09e1fd97/attachment-0001.html>
More information about the Plasma-devel
mailing list