Review Request 125990: [Widget Explorer] Fix applet uninstall

Kai Uwe Broulik kde at privat.broulik.de
Mon Nov 16 20:31:19 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125990/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 8:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit fe5ee9c72360c648c85b3ade3821c629b7978ef7 by Kai Uwe Broulik to branch master.


Repository: plasma-workspace


Description
-------

QStandardPaths doesn't add a trailing slash, nor does PLASMA_RELATIVE_DATA_INSTALL_DIR have a leading slash. Also, apparently we need a structure also for uninstall but then we can remove the setPath because we tell that to uninstall...

Not sure if we're doing something wrong to begin with here, though.


Diffs
-----

  components/shellprivate/widgetexplorer/widgetexplorer.cpp 0922c18 

Diff: https://git.reviewboard.kde.org/r/125990/diff/


Testing
-------

Works now.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/96143cc8/attachment.html>


More information about the Plasma-devel mailing list