Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88414
-----------------------------------------------------------

Ship it!



src/declarativeimports/plasmacomponents/qmenu.cpp (line 223)
<https://git.reviewboard.kde.org/r/126061/#comment60599>

    maybe instead a qMin(screen height - menu height, pos.y()) ?


- Marco Martin


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> QMenu is smart enough not to position itself outside the screen, however this can mean that the button the Menu originated from, could be covered. This can be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> -------
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of popup(0, height) to have the menu pop up below the button. Now it pops up above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/757266b6/attachment.html>