Review Request 126079: Keep drag and drop in range on both sides
David Edmundson
david at davidedmundson.co.uk
Mon Nov 16 11:33:17 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126079/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 11:33 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 69c8e809da579a3a5318511a6fb4fbb8d7d5b523 by David Edmundson to branch master.
Repository: plasma-desktop
Description
-------
If dragging halfway above the top entry we end up with targetRow == -1
which then tried to access out of bounds and crashes.
BUG: 355365
Diffs
-----
applets/kickoff/package/contents/ui/FavoritesView.qml 901b80a2343700ca4054bc46aee703f0cfd26372
Diff: https://git.reviewboard.kde.org/r/126079/diff/
Testing
-------
Dragged in all places, seems to still work.
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/86daeb3e/attachment.html>
More information about the Plasma-devel
mailing list