Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

[Bhushan Shah]

> On Nov. 15, 2015, 4:06 p.m., Bhushan Shah wrote:
> > startkde/startplasma.cmake, line 35
> > <https://git.reviewboard.kde.org/r/126022/diff/1/?file=416125#file416125line35>
> >
> >     Please adjust kwin_wayland call to use this environment variable, i.e pass --lockscreen to kwin_wayland if it is set.
> 
> Martin Gräßlin wrote:
>     There are two possible ways to do it: we can change the startplasmacompositor to pass --lockscreen or we read the env variable in KWin. I'm open to both.

Okay, then we can do it from kwin. Ship it!


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126022/#review88377
-----------------------------------------------------------


On Nov. 11, 2015, 2:40 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126022/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 2:40 p.m.)
> 
> 
> Review request for Plasma and Bhushan Shah.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> On Wayland ksmserver should not be responsible for the lockscreen,
> but the compositor takes care of providing the lock screen. To prevent
> conflicts KSMServer gets a new command line option to enable it.
> 
> The code is slightly changed to not pass a series of boolean flags to
> KSMServer, but a flags type.
> 
> The startplasma script for Wayland is adjusted to start ksmserver with
> the new command line option.
> 
> 
> Diffs
> -----
> 
>   ksmserver/main.cpp b1f1b68fe41b86da42d7bea2c088db6d89f0d844 
>   ksmserver/server.h 87e46cbad70913b83f976ea2938606042c653c69 
>   ksmserver/server.cpp ffb15d230b927c5ee28b7196904e0061a14b2d09 
>   startkde/startplasma.cmake 4fab3b1597fee40bf69551af895d5248955eadea 
> 
> Diff: https://git.reviewboard.kde.org/r/126022/diff/
> 
> 
> Testing
> -------
> 
> Started a Plasma/Wayland session with the change.
> 
> * ksmserver is started with --no-lockscreen
> * Using loginctl lock-session gives me one lock window, instead of two as before
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/e7172557/attachment.html>