Review Request 126014: fix: kcms/input and kcms/touchpad should not be built if XInput is not present.

[Martin Gräßlin]

> On Nov. 10, 2015, 4:15 p.m., Martin Gräßlin wrote:
> > Ship It!
> 
> Johan Ouwerkerk wrote:
>     Please note: I do not have commit access (just a KDE identity account) so please pull these changes because I cannot commit them!

as you did quite a few patches recently: interested in getting an account to push yourself? Please see https://techbase.kde.org/Contribute/Get_a_Contributor_Account


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126014/#review88217
-----------------------------------------------------------


On Nov. 10, 2015, 3:22 p.m., Johan Ouwerkerk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126014/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 3:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Previously the presence of evdev headers would enable the kcms/input KCM module, and the presence of synaptics driver headers would enable the touchpad module.
> However, both KCMs unconditionally depend on XInput in some way in a (sub) CMakelists.txt file and deliberately break the build if it is not present or not properly detected.
> 
> As per the convention in the KCM modules shipped by plasma-desktop, inclusion of the kcms/input and kcms/touchpad subdirectory is made conditional on XInput being present and properly detected during the cmake configure stage.
> 
> This patch can be pulled from the fix-cmake-xinput-dep branch at: git at github.com:cmacq2/plasma-desktop.git
> 
> 
> Diffs
> -----
> 
>   kcms/CMakeLists.txt 321fbebba49dad32d237f3941dea9fedaf1a8e5a 
> 
> Diff: https://git.reviewboard.kde.org/r/126014/diff/
> 
> 
> Testing
> -------
> 
> Built without XInput development files, using kdesrc-build.
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151116/9bf32f98/attachment-0001.html>