Review Request 125990: [Widget Explorer] Fix applet uninstall
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Nov 15 23:27:05 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125990/#review88391
-----------------------------------------------------------
A unit test there would be as good as chocolate cake.
- Aleix Pol Gonzalez
On Nov. 15, 2015, 4:06 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125990/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2015, 4:06 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> QStandardPaths doesn't add a trailing slash, nor does PLASMA_RELATIVE_DATA_INSTALL_DIR have a leading slash. Also, apparently we need a structure also for uninstall but then we can remove the setPath because we tell that to uninstall...
>
> Not sure if we're doing something wrong to begin with here, though.
>
>
> Diffs
> -----
>
> components/shellprivate/widgetexplorer/widgetexplorer.cpp 0922c18
>
> Diff: https://git.reviewboard.kde.org/r/125990/diff/
>
>
> Testing
> -------
>
> Works now.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151115/f3cf1ae2/attachment.html>
More information about the Plasma-devel
mailing list