Review Request 126013: fix: kacess should not be built if xkb is not present

[Johan Ouwerkerk]

> On Nov. 10, 2015, 1:26 a.m., David Edmundson wrote:
> > Ship It!
> 
> Johan Ouwerkerk wrote:
>     Forgot to mention that the patch can be pulled from the fix-cmake-xkb-dep branch at: git at github.com:cmacq2/plasma-desktop.git

Please note: I do not have commit access (just a KDE identity account) so please pull these changes because I cannot commit them!


- Johan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126013/#review88208
-----------------------------------------------------------


On Nov. 10, 2015, 12:52 a.m., Johan Ouwerkerk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126013/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 12:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The XCB-XKB dependency of plasma-desktop is optional, however kacess depends directly and unconditionally on the xcb/xkb.h header file.
> This causes the build of plasma-desktop to fail at compile stage if the xkb header is not present.
> 
> As per the convention in the kcm modules shipped by plasma-desktop, inclusion of the kacess subdirectory is made conditional on XKB being present and properly detected during the cmake configure stage.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 193238a8dcbb2c6e2bda01c390c57ff2ecfebeb0 
> 
> Diff: https://git.reviewboard.kde.org/r/126013/diff/
> 
> 
> Testing
> -------
> 
> Built without xkb header, using kdesrc-build
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151114/8c1f90b5/attachment.html>