Review Request 125993: Implemented lastfmimagefetcher as a Plugin

Aditya Dev Sharma aditya.sharma15696 at gmail.com
Thu Nov 12 16:23:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
-----------------------------------------------------------

(Updated Nov. 12, 2015, 4:23 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
-------

Implemented it like the other datasources.


Diffs (updated)
-----

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/pmcimagecache.h 6399461 
  libs/mediacenter/pmcimagecache.cpp fcfe2a8 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
-------

Built and Tested.


Thanks,

Aditya Dev Sharma

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151112/45210066/attachment-0001.html>


More information about the Plasma-devel mailing list