Review Request 125951: [calendar] Move the plugins handling to a separate class

Martin Klapetek martin.klapetek at gmail.com
Wed Nov 11 19:54:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/
-----------------------------------------------------------

(Updated Nov. 11, 2015, 8:54 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Restructured things a bit
* it now ensures that the applet config is not actually loading the plugins, it operates only on the metadata
* the list of enabled plugins is now stored per applet in plasmoid.configuration.enabledCalendarPlugins (this is the applet code though so that's another patch)

Enabling and disabling the plugins now work correctly including adding/removing the events from the calendar.


Repository: plasma-framework


Description
-------

This is also made a QML singleton that will be used for the applet
config view where it will add the plugin configs once we add that
possibility.

The same instance is then set to the DaysModel from QML.

(this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)


Diffs (updated)
-----

  src/declarativeimports/calendar/qml/MonthView.qml f698934f850ef3a917b9611c9f9a40c369b23f6c 
  src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION 
  src/declarativeimports/calendar/daysmodel.h a5bdac98627f7efa76bd4afd239469b53e06690b 
  src/declarativeimports/calendar/CMakeLists.txt 40ead911ad5208cae5dbe5333d227f9f8a0d9154 
  src/declarativeimports/calendar/calendarplugin.cpp bafe80cf7520a08312abfd1dbd6d4648a6710175 
  src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION 
  src/declarativeimports/calendar/daysmodel.cpp 2d059a8e8636565adbe52811e602fff37a5eb157 

Diff: https://git.reviewboard.kde.org/r/125951/diff/


Testing
-------

Calendar events are still correctly displayed


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151111/b0286a76/attachment.html>


More information about the Plasma-devel mailing list