Review Request 126012: Fix crash if context gets unrefd

David Edmundson david at davidedmundson.co.uk
Wed Nov 11 12:37:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126012/
-----------------------------------------------------------

(Updated Nov. 11, 2015, 12:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Harald Sitter.


Changes
-------

Submitted with commit 5d46f6c2a767c25868c143ee64ef71e071a7a55b by David Edmundson to branch master.


Repository: plasma-pa


Description
-------

Context is refcounted (using it's own internal mechanism for whatever
reason)

However, when the last ref is deleted it leaves a dangling pointer in
instance(). When a new object is created it returns that.

This unsets our static pointer when deleting the context object

BUG: 354510


Diffs
-----

  src/context.h 3b4ada12c307dfa53f4f29cafae41518d8b5422d 
  src/context.cpp ac8f0326641e36f0ea7388df718ad52a3eede260 

Diff: https://git.reviewboard.kde.org/r/126012/diff/


Testing
-------

Still loads as before.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151111/71841d76/attachment-0001.html>


More information about the Plasma-devel mailing list