Review Request 126022: [ksmserver] Add a dedicated --no-lockscreen command line option

[Martin Graesslin]

On Wednesday, November 11, 2015 3:45:53 PM CET Bhushan Shah wrote:
> I kinda don't like idea of the command line option.. For instance if
> someone uses this option on X11 they are lift without lockscreen.. Any
> other solution possible?

I don't think that is an actual threat. This requires modifying startkde 
(which needs root privs). If users want to shoot into their feet: sure let 
them.

> 
> Ideally ksmserver should just retire in Wayland world imo and other
> functionality of it should be split out of it..

Ideally yes. Practically: I run away from that screaming. It still has a lot 
of startup code and I don't think we will be able to migrate that code fast. 
So we need a solution till ksmserver gets retired.

Cheers
Martin

> 
> On Nov 11, 2015 2:40 PM, "Martin Gräßlin" <mgraesslin at kde.org> wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/126022/
> > Review request for Plasma and Bhushan Shah.
> > By Martin Gräßlin.
> > *Repository: * plasma-workspace
> > Description
> > 
> > On Wayland ksmserver should not be responsible for the lockscreen,
> > but the compositor takes care of providing the lock screen. To prevent
> > conflicts KSMServer gets a new command line option to enable it.
> > 
> > The code is slightly changed to not pass a series of boolean flags to
> > KSMServer, but a flags type.
> > 
> > The startplasma script for Wayland is adjusted to start ksmserver with
> > the new command line option.
> > 
> > Testing
> > 
> > Started a Plasma/Wayland session with the change.
> > 
> >    - ksmserver is started with --no-lockscreen
> >    - Using loginctl lock-session gives me one lock window, instead of two
> >    as before> 
> > Diffs
> > 
> >    - ksmserver/main.cpp (b1f1b68fe41b86da42d7bea2c088db6d89f0d844)
> >    - ksmserver/server.h (87e46cbad70913b83f976ea2938606042c653c69)
> >    - ksmserver/server.cpp (ffb15d230b927c5ee28b7196904e0061a14b2d09)
> >    - startkde/startplasma.cmake (4fab3b1597fee40bf69551af895d5248955eadea)
> > 
> > View Diff <https://git.reviewboard.kde.org/r/126022/diff/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151111/46799f5c/attachment.sig>