Review Request 126012: Fix crash if context gets unrefd

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126012/#review88214
-----------------------------------------------------------


LGTM. Best have sebas call the shipit though.

Why it is using manual refcounting I can't recall. IIRC switching to a sharedptr would only require changes to the Context and Ref class though, so that might be a junior job to write down somewhere.

- Harald Sitter


On Nov. 9, 2015, 10:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126012/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 10:28 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Context is refcounted (using it's own internal mechanism for whatever
> reason)
> 
> However, when the last ref is deleted it leaves a dangling pointer in
> instance(). When a new object is created it returns that.
> 
> This unsets our static pointer when deleting the context object
> 
> BUG: 354510
> 
> 
> Diffs
> -----
> 
>   src/context.h 3b4ada12c307dfa53f4f29cafae41518d8b5422d 
>   src/context.cpp ac8f0326641e36f0ea7388df718ad52a3eede260 
> 
> Diff: https://git.reviewboard.kde.org/r/126012/diff/
> 
> 
> Testing
> -------
> 
> Still loads as before.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151110/79da58ba/attachment-0001.html>