Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

Jonathan Marten jjm at keelhaul.me.uk
Mon Nov 9 13:29:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/
-----------------------------------------------------------

(Updated Nov. 9, 2015, 1:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 78f02ac2ed40e88d6f069f35794d991b40a33139 by Jonathan Marten to branch master.


Bugs: 354984
    https://bugs.kde.org/show_bug.cgi?id=354984


Repository: plasma-desktop


Description
-------

See the referenced bug.  The special locale value "C" needs to be written out as simply that and not with an encoding suffix added, otherwise the resulting value is not accepted by the locale system.


Diffs
-----

  kcms/formats/kcmformats.cpp ea9dece 

Diff: https://git.reviewboard.kde.org/r/125984/diff/


Testing
-------

Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, checked correct operation of desktop and of CLI and GUI applications.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151109/b2927a7e/attachment.html>


More information about the Plasma-devel mailing list