Review Request 125997: Catch other openGL error gracefully

[Martin Gräßlin]

> On Nov. 9, 2015, 7:57 a.m., Martin Gräßlin wrote:
> > Could you please explain the change? Reduce string comparison?
> > 
> > Anyway: we should probably extend the checks to also include the EGL/XCB error messages an EGL/Wayland error messages
> 
> David Edmundson wrote:
>     there's a second 
>     
>     if message == "blah"
>     which is the main important change
>     
>     then I added the if Q_UNLIKELY to potentially speed things up as 99.9999% of the time it will be debug not fatal messages.
>     
>     then I reformatted it so it was a bit cleaner as I ended up 4 brackets deep

thanks. Now I see the change to the second message.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125997/#review88172
-----------------------------------------------------------


On Nov. 8, 2015, 10:07 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125997/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 10:07 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> CCBUG: 354966
> CCBUG: 355054
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp a774cb4e8d18032ff3fd39892b8171b96a94cc92 
> 
> Diff: https://git.reviewboard.kde.org/r/125997/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151109/1f846c15/attachment.html>