Review Request 125993: Implemented lastfmimagefetcher as a Plugin

[Bhushan Shah]

> On Nov. 8, 2015, 6:11 p.m., Bhushan Shah wrote:
> > datasources/lastfm/CMakeLists.txt, line 2
> > <https://git.reviewboard.kde.org/r/125993/diff/1/?file=415728#file415728line2>
> >
> >     You sure this builds? there is no datasources/lastfm/lastfmimagefetcher.cpp ?

Sorry, I somehow mis-read diff..


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88159
-----------------------------------------------------------


On Nov. 8, 2015, 6:02 p.m., Aditya Dev Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 6:02 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Implemented it like the other datasources.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> -------
> 
> Built and Tested.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151108/75d95300/attachment-0001.html>