Review Request 125984: kcm_formats: Do not write out an unusable value for the "C" locale

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125984/#review88137
-----------------------------------------------------------


Looks good, a coding style comment inline, though.


kcms/formats/kcmformats.cpp (line 124)
<https://git.reviewboard.kde.org/r/125984/#comment60455>

    spaces around the comparison operator, please.


- Sebastian Kügler


On Nov. 7, 2015, 1:14 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125984/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2015, 1:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 354984
>     https://bugs.kde.org/show_bug.cgi?id=354984
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> See the referenced bug.  The special locale value "C" needs to be written out as simply that and not with an encoding suffix added, otherwise the resulting value is not accepted by the locale system.
> 
> 
> Diffs
> -----
> 
>   kcms/formats/kcmformats.cpp ea9dece 
> 
> Diff: https://git.reviewboard.kde.org/r/125984/diff/
> 
> 
> Testing
> -------
> 
> Built plasma-desktop with these changes, reset 'kcmshell5 formats' settings, checked correct operation of desktop and of CLI and GUI applications.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151107/816ca506/attachment-0001.html>