Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

> On Nov. 5, 2015, 9:22 p.m., Marco Martin wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 692
> > <https://git.reviewboard.kde.org/r/125968/diff/1/?file=415533#file415533line692>
> >
> >     kpackagetool in the case of the upgrade switch launches a remove job first then an install.
> >     perhaps i should change the job in kpackage to launch an internal uninstall and reinstall if the version of the new is higher..
> >     but i'm not sure all this complexity is good in the install job, or if i should perhaps do an "info" job to retrieve the metadata of a .plasmoid and then having the client code to decide what to do with it (remove and reinstall if needed)
> 
> Marco Martin wrote:
>     2.) How can I get the pluginId of the applet? KPackage::metadata() is deprecated.
>     uuuh, it's not?
>     (but for compressed packages yes, i think should be a job)
> 
> Kai Uwe Broulik wrote:
>     What do you mean by "upgrade switch"?

kpackagetool -u whatever.plasmoid


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88061
-----------------------------------------------------------


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> -------
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a KJob allowing to track installation progress". I don't see a way to check for "applet already installed" (should update existing one if newer?) or "installation failed". In the former case I just want to add the already installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no way to uninstall user-installed applets :/ Perhaps a delete button with undo like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151106/c7aaf919/attachment.html>