Review Request 125961: [declarative/core] Use BypassWindowManagerHint only on platform X11

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125961/#review88056
-----------------------------------------------------------

Ship it!


good as short term, but would love apps not suiciding when that flag is set. would need a fix in qtwayland i guess

- Marco Martin


On Nov. 5, 2015, 3:38 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125961/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 3:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> BypassWindowManagerHint is a flag which is X11 specific. Because of
> that for example QtWayland doesn't create a real window for QWindows
> with this flag.
> 
> Using such a window will eventually result in a freeze of the whole
> application. If one renders with QtQuick to such a window, mesa will
> request a frame callback from the compositor. Just the compositor
> will never deliver the frame rendered callback as it doesn't know the
> window exists in the first place and by that doesn't render it and
> will never ever deliver the frame rendered callback.
> 
> If now one tries to render another frame, mesa notices that it hasn't
> got the frame callback and will block the thread till that happens.
> With the setup described: that's until eternity.
> 
> Change-Id: I352ff788f90799ce0e0a5de53d5d34c02c8468c3
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/CMakeLists.txt 4e0fe8bf95d51c282060a0a05914c976cd4e5783 
>   src/declarativeimports/core/config-x11.h.cmake PRE-CREATION 
>   src/declarativeimports/core/tooltipdialog.cpp 121ccf91bb17c5dd17e0742831830186e9e44a1e 
> 
> Diff: https://git.reviewboard.kde.org/r/125961/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151105/2391443e/attachment.html>