Review Request 125954: [wayland] Start lockscreen from the WaylandServer

Bhushan Shah bhush94 at gmail.com
Thu Nov 5 13:28:00 UTC 2015



> On Nov. 5, 2015, 6:56 p.m., Thomas Lübking wrote:
> > wayland_server.cpp, line 213
> > <https://git.reviewboard.kde.org/r/125954/diff/1/?file=415463#file415463line213>
> >
> >     why's this constructed unconditionally?

Because it is supposed to, to lock immediately  or not is option. but not to lock at all is not.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125954/#review88047
-----------------------------------------------------------


On Nov. 5, 2015, 6:46 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125954/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:46 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> This patch introduces dep to newly created kscreenlocker patch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 369f9c4e644abc0251feb30cc7917e5a411b7ef7 
>   main_wayland.cpp fc09aa7af9d618857cbc2a89f3eddfbdcbe56e28 
>   wayland_server.h 2be2d2272e07520711b6e249cd551e5b6fd4e2db 
>   wayland_server.cpp 3bbf59f2944419ea17059c345bd3b05eadc11fd7 
> 
> Diff: https://git.reviewboard.kde.org/r/125954/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151105/993158a6/attachment.html>


More information about the Plasma-devel mailing list