Review Request 125951: [calendar] Move the plugins handling to a separate class

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/#review88031
-----------------------------------------------------------


which class is going to get the property where you write the config option, eventpluginmanager or daysmodel?


src/declarativeimports/calendar/calendarplugin.cpp (line 33)
<https://git.reviewboard.kde.org/r/125951/#comment60404>

    leaks
    
    why are you setting cpp ownership anyway?



src/declarativeimports/calendar/daysmodel.cpp (line 218)
<https://git.reviewboard.kde.org/r/125951/#comment60405>

    you can't delete an object owned by someone else
    
    (also you need to disconnect)



src/declarativeimports/calendar/daysmodel.cpp (line 226)
<https://git.reviewboard.kde.org/r/125951/#comment60406>

    what if this is called before setSource?


- David Edmundson


On Nov. 4, 2015, 7:24 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125951/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 7:24 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is also made a QML singleton that will be used for the applet
> config view where it will add the plugin configs once we add that
> possibility.
> 
> The same instance is then set to the DaysModel from QML.
> 
> (this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/CMakeLists.txt 40ead911ad5208cae5dbe5333d227f9f8a0d9154 
>   src/declarativeimports/calendar/calendarplugin.cpp bafe80cf7520a08312abfd1dbd6d4648a6710175 
>   src/declarativeimports/calendar/daysmodel.h a5bdac98627f7efa76bd4afd239469b53e06690b 
>   src/declarativeimports/calendar/daysmodel.cpp 2d059a8e8636565adbe52811e602fff37a5eb157 
>   src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION 
>   src/declarativeimports/calendar/qml/MonthView.qml f698934f850ef3a917b9611c9f9a40c369b23f6c 
> 
> Diff: https://git.reviewboard.kde.org/r/125951/diff/
> 
> 
> Testing
> -------
> 
> Calendar events are still correctly displayed
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151105/9c8a9253/attachment-0001.html>