Review Request 125871: WIP: task geometries to wayland for minimize effect

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125871/#review88016
-----------------------------------------------------------



src/server/plasmawindowmanagement_interface.cpp (line 91)
<https://git.reviewboard.kde.org/r/125871/#comment60397>

    the setter differs from the getter?



src/server/plasmawindowmanagement_interface.cpp (line 461)
<https://git.reviewboard.kde.org/r/125871/#comment60400>

    mitted unconditionally (on idempotent sets)



src/server/plasmawindowmanagement_interface.cpp (line 463)
<https://git.reviewboard.kde.org/r/125871/#comment60398>

    stray semicolon



src/server/plasmawindowmanagement_interface.cpp (line 479)
<https://git.reviewboard.kde.org/r/125871/#comment60399>

    emitted unconditionally


sorry for the post review (and in case this has been addressed for the ultimate commt)

- Thomas Lübking


On Nov. 4, 2015, 12:21 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125871/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 12:21 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> this exposes the geometry of taskbar entries in plasma-windowmanagement, in order to make the minimize effects possible.
> unlike on X11, it takes relative positions and it has one geometry per panel, making possible to have multiple taskbars working.
> 
> however this is still not completely exposed, as internally kwin has still only one geometry, it will need a change in kwin itself (suggestions welcome) probably the rotocol will need also a minimizeTo function that takes the panel as argument.
> 
> another thing completely missing is tests: unfortunately the whole plasma-windowmanagement doesn't have any autotest yet :/
> 
> 
> Diffs
> -----
> 
>   src/client/plasmawindowmanagement.cpp 1f9674c 
>   src/client/plasmawindowmanagement.h abd8fa6 
>   autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION 
>   autotests/client/CMakeLists.txt 1556c47 
>   src/client/plasmawindowmodel.h 5a6aac4 
>   src/client/plasmawindowmodel.cpp 355ef53 
>   src/client/protocols/plasma-window-management.xml ca6a7cc 
>   src/server/plasmawindowmanagement_interface.h 6ccc22e 
>   src/server/plasmawindowmanagement_interface.cpp ad714a5 
> 
> Diff: https://git.reviewboard.kde.org/r/125871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151104/8fec4592/attachment-0001.html>