Review Request 124536: Expose immutable config options in ConfigPropertyMap

David Edmundson david at davidedmundson.co.uk
Tue Nov 3 20:19:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124536/#review87957
-----------------------------------------------------------


+1 looks good


src/kdeclarative/configpropertymap.h (line 42)
<https://git.reviewboard.kde.org/r/124536/#comment60346>

    docs please


- David Edmundson


On Nov. 3, 2015, 8 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124536/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 8 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This exposes a hash of immutable config options through the "immutables" property. I tried adding a Q_INVOKABLE which would be much nicer but me and Dan tried everything but couldn't make it work.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/configpropertymap.h f2a22ed 
>   src/kdeclarative/configpropertymap.cpp 614d157 
> 
> Diff: https://git.reviewboard.kde.org/r/124536/diff/
> 
> 
> Testing
> -------
> 
> Works, I can not grey out immutable config options in Plasma
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151103/b0699204/attachment-0001.html>


More information about the Plasma-devel mailing list