Review Request 125871: WIP: task geometries to wayland for minimize effect

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125871/#review87912
-----------------------------------------------------------



autotests/client/test_wayland_windowmanagement.cpp (line 137)
<https://git.reviewboard.kde.org/r/125871/#comment60313>

    nitpick



src/client/plasmawindowmanagement.h (line 242)
<https://git.reviewboard.kde.org/r/125871/#comment60309>

    @since 5.5



src/client/plasmawindowmodel.h (line 120)
<https://git.reviewboard.kde.org/r/125871/#comment60310>

    I guess you wanted to add something here?



src/client/protocols/plasma-window-management.xml (line 116)
<https://git.reviewboard.kde.org/r/125871/#comment60311>

    just some thought: should we make it a more general way and use wl_surface? This would probably make it more future compatible in case we want ways which don't have a plasma surface in future.



src/server/plasmawindowmanagement_interface.h (line 109)
<https://git.reviewboard.kde.org/r/125871/#comment60312>

    a const signal?


- Martin Gräßlin


On Nov. 3, 2015, 11:08 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125871/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 11:08 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> this exposes the geometry of taskbar entries in plasma-windowmanagement, in order to make the minimize effects possible.
> unlike on X11, it takes relative positions and it has one geometry per panel, making possible to have multiple taskbars working.
> 
> however this is still not completely exposed, as internally kwin has still only one geometry, it will need a change in kwin itself (suggestions welcome) probably the rotocol will need also a minimizeTo function that takes the panel as argument.
> 
> another thing completely missing is tests: unfortunately the whole plasma-windowmanagement doesn't have any autotest yet :/
> 
> 
> Diffs
> -----
> 
>   autotests/client/CMakeLists.txt 1556c47 
>   autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION 
>   src/client/plasmawindowmanagement.h abd8fa6 
>   src/client/plasmawindowmanagement.cpp 1f9674c 
>   src/client/plasmawindowmodel.h 5a6aac4 
>   src/client/plasmawindowmodel.cpp 355ef53 
>   src/client/protocols/plasma-window-management.xml ca6a7cc 
>   src/server/plasmashell_interface.h 9db3f52 
>   src/server/plasmashell_interface.cpp d29d7bc 
>   src/server/plasmawindowmanagement_interface.h 6ccc22e 
>   src/server/plasmawindowmanagement_interface.cpp ad714a5 
> 
> Diff: https://git.reviewboard.kde.org/r/125871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151103/5fd0b034/attachment-0001.html>