Review Request 125927: Unbox QJSValue in config property map

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125927/#review87896
-----------------------------------------------------------

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Nov. 3, 2015, 2:14 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125927/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 2:14 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Currently if one saves a QJSValue into the property map we save the
> correct real value, but the propertymap still holds the data as a
> QJSValue when retrieved.
> 
> This causes an error if a property map is moved between engines as a
> QJSValue can only be in one. This can be seen in the system tray where
> you can't configure entries on the first load.
> 
> By using the updateValue we can intercept updates QML and the property
> map making sure only real datatypes are stored in our map.
> 
> 
> Diffs
> -----
> 
>   src/kdeclarative/configpropertymap.h 21a10fcb56c2929fcb43a3387566c101aa16e90f 
>   src/kdeclarative/configpropertymap.cpp 93c49a3b1f5929a85754e30704821a36717d4f5d 
> 
> Diff: https://git.reviewboard.kde.org/r/125927/diff/
> 
> 
> Testing
> -------
> 
> plasmoidviewer -a org.kde.plasma.systemtray - can conifgure entries \o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151103/b15114f7/attachment.html>