Review Request 125926: [Image Wallpaper] Take into account orientation

Kai Uwe Broulik kde at privat.broulik.de
Mon Nov 2 21:31:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125926/#review87889
-----------------------------------------------------------


Damn, of course, it should take the non-fitting orientation as a last resort if it actually is a vertical photograph...

- Kai Uwe Broulik


On Nov. 2, 2015, 9:27 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125926/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 9:27 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352555
>     https://bugs.kde.org/show_bug.cgi?id=352555
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The distance method only cares for a match in terms of pixel numbers, not the actual orientation.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/image.cpp 1b8d2dd 
> 
> Diff: https://git.reviewboard.kde.org/r/125926/diff/
> 
> 
> Testing
> -------
> 
> Placed a 1440x2560 picture in my image package, it used to get picked and stretched, not it properly takes the 2560x1440 image consistently, or if not present, fall back to a different resolution image.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/f1d94f22/attachment-0001.html>


More information about the Plasma-devel mailing list