Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/#review87848
-----------------------------------------------------------


looks good to me. Not giving a ship it as I want to have at least one more person to review it.


ksmserver/screenlocker/CMakeLists.txt (line 7)
<https://git.reviewboard.kde.org/r/125892/#comment60278>

    you dropped the debug area? That's fine but should also go into the cleanup commit.


- Martin Gräßlin


On Nov. 2, 2015, 8:44 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125892/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 8:44 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> To split libksld it is required that it no longer depends upon ksmserver being parent dir.
> 
> I am just unsure about removal of,
> 
> set(ksmserver_xml  ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
> and
> qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)
> 
> 
> Diffs
> -----
> 
>   ksmserver/config-ksmserver.h.cmake f24e62d 
>   ksmserver/screenlocker/CMakeLists.txt 4213713 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
>   ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
>   ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 
>   ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
>   ksmserver/screenlocker/kcm/kcm.cpp 0533449 
>   ksmserver/screenlocker/ksldapp.cpp d4c4c83 
>   ksmserver/screenlocker/waylandserver.cpp f8ef665 
> 
> Diff: https://git.reviewboard.kde.org/r/125892/diff/
> 
> 
> Testing
> -------
> 
> builds, installs, tests pass
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/be8a2daf/attachment-0001.html>