Review Request 125873: preliminar support for task geometries in wayland

[Martin Gräßlin]

> On Oct. 30, 2015, 5:52 p.m., Thomas Lübking wrote:
> > shell_client.cpp, line 412
> > <https://git.reviewboard.kde.org/r/125873/diff/5/?file=413725#file413725line412>
> >
> >     should the panel also be tested for being on the same screen (ie. same screen takes precedence over closer, but other screen)?
> 
> Marco Martin wrote:
>     yep, good idea absolutely :)
>     
>     are the screens of ShellClient and of the PlasmaShellSurface accessible from there?

yes, there's a int screen() const available and also a bool isOnScreen(int) const. The isOnScreen also returns true if the window overlaps. So I'd rather go for comparing the result of screen(). That's all on Toplevel, PlasmaShellSurface doesn't have a screen, but you can get the ShellClient for the PlasmaShellSurface.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review87753
-----------------------------------------------------------


On Oct. 30, 2015, 6:42 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 6:42 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> make the minimize effect work by reading taskGeometry from plasmawindowmanagement and returning as iconGeometry().
> 
> It still supports a single taskbar as on x11. the architecture will have to change somehow to allow to know from where panel we want to minimize (or if not secified searching for the nearest panel)
> suggestions welcome :)
> 
> 
> Diffs
> -----
> 
>   abstract_client.h 128c141 
>   client.h f22e690 
>   shell_client.h fee22c4 
>   shell_client.cpp 79a1ac5 
> 
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/4af245b8/attachment.html>