Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

[Bhushan Shah]

> On Nov. 2, 2015, 1:08 p.m., Martin Gräßlin wrote:
> > ksmserver/config-ksmserver.h.cmake, line 2
> > <https://git.reviewboard.kde.org/r/125892/diff/1/?file=413861#file413861line2>
> >
> >     are you sure that one is not needed by ksmserver?

Oops, it is needed by ksmserver but not screenlocker


> On Nov. 2, 2015, 1:08 p.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/125892/diff/1/?file=413862#file413862line18>
> >
> >     if that's no longer needed by ksld I would make it a dedicated commit to remove "no longer needed code", instead of mixing with this change.

If this gets ship it, I will do it in two commits


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125892/#review87841
-----------------------------------------------------------


On Oct. 31, 2015, 6:11 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125892/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 6:11 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> To split libksld it is required that it no longer depends upon ksmserver being parent dir.
> 
> I am just unsure about removal of,
> 
> set(ksmserver_xml  ${PROJECT_SOURCE_DIR}/ksmserver/org.kde.KSMServerInterface.xml)
> and
> qt5_add_dbus_interface(ksld_SRCS ${ksmserver_xml} ksmserver_interface)
> 
> 
> Diffs
> -----
> 
>   ksmserver/config-ksmserver.h.cmake f24e62d 
>   ksmserver/screenlocker/CMakeLists.txt 4213713 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 51eb0fe 
>   ksmserver/screenlocker/config-kscreenlocker.h.cmake PRE-CREATION 
>   ksmserver/screenlocker/greeter/CMakeLists.txt 942d88c 
>   ksmserver/screenlocker/greeter/authenticator.cpp 4d916a1 
>   ksmserver/screenlocker/greeter/autotests/CMakeLists.txt 4244a2a 
>   ksmserver/screenlocker/waylandserver.cpp f8ef665 
>   ksmserver/screenlocker/ksldapp.cpp f062082 
>   ksmserver/screenlocker/kcm/kcm.cpp 751b566 
>   ksmserver/screenlocker/kcm/CMakeLists.txt c5c62be 
>   ksmserver/screenlocker/greeter/autotests/killtest.cpp 363c9f0 
> 
> Diff: https://git.reviewboard.kde.org/r/125892/diff/
> 
> 
> Testing
> -------
> 
> builds, installs, tests pass
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/194ae63e/attachment.html>