Review Request 125916: [kcm icons] Take into account device pixel ratio for icon preview
David Edmundson
david at davidedmundson.co.uk
Mon Nov 2 00:42:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125916/#review87833
-----------------------------------------------------------
kcms/icons/iconthemes.cpp (line 440)
<https://git.reviewboard.kde.org/r/125916/#comment60268>
dpr
kcms/icons/iconthemes.cpp (line 443)
<https://git.reviewboard.kde.org/r/125916/#comment60269>
you sure we need this?
Looking at QPainter code we shouldn't.
- David Edmundson
On Nov. 1, 2015, 11:49 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125916/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2015, 11:49 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Take into account device pixel ratio for icon theme preview
>
>
> Diffs
> -----
>
> kcms/icons/iconthemes.cpp 5304cf6
>
> Diff: https://git.reviewboard.kde.org/r/125916/diff/
>
>
> Testing
> -------
>
> No more blurry Breeze icons. Oxygen is blocky here a bit because the default size is 48px and there is no 96px icon size.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151102/513244b0/attachment-0001.html>
More information about the Plasma-devel
mailing list