Review Request 125848: [kscreenlocker_greet] Fix QML fallback
Kai Uwe Broulik
kde at privat.broulik.de
Sun Nov 1 15:30:32 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125848/
-----------------------------------------------------------
(Updated Nov. 1, 2015, 3:30 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Martin Gräßlin.
Changes
-------
Submitted with commit 5ce2e2b707db361a5e2377341167221dab3be190 by Kai Uwe Broulik to branch master.
Repository: plasma-workspace
Description
-------
With the change to the QQuickSharedEngine, it seems to load synchronously, meaning the status changed slot is never called and when I broke my lockscreen I locked myself out in the process.
Diffs
-----
ksmserver/screenlocker/greeter/greeterapp.h becd669
ksmserver/screenlocker/greeter/greeterapp.cpp a88b61a
Diff: https://git.reviewboard.kde.org/r/125848/diff/
Testing
-------
Broke my lock screen. Got the fallback.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151101/d5149d4e/attachment.html>
More information about the Plasma-devel
mailing list