Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out
Kai Uwe Broulik
kde at privat.broulik.de
Sun Nov 1 15:13:09 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125913/
-----------------------------------------------------------
Review request for Plasma.
Bugs: 346050
https://bugs.kde.org/show_bug.cgi?id=346050
Repository: plasma-desktop
Description
-------
This removes the custom TextLabel and uses an OpacityMask to fade out the label.
Diffs
-----
applets/taskmanager/CMakeLists.txt 3c94cb7
applets/taskmanager/package/contents/ui/Task.qml 9350481
applets/taskmanager/plugin/taskmanagerplugin.cpp 1be1fed
applets/taskmanager/plugin/textlabel.h f5f6de2
applets/taskmanager/plugin/textlabel.cpp f916384
Diff: https://git.reviewboard.kde.org/r/125913/diff/
Testing
-------
Label is faded out on regular entries and in popup when gets too wide. When gets too narrow label is properly hidden, launchers work fine, too. But there are probably many other usecases and scenarios I didn't know/test.
Also fixes task manager label with QT_DEVICE_PIXELRATIO > 1 (if we were to enable that)
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151101/8d4948b4/attachment.html>
More information about the Plasma-devel
mailing list