Review Request 125908: taskmanager: Make the windows in tooltip scrollable
Kai Uwe Broulik
kde at privat.broulik.de
Sun Nov 1 14:20:05 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review87801
-----------------------------------------------------------
> Remove expression for interactive as it doesn't work with ScrollArea anyway.
You need to override that in Component.onCompleted (eg. Component.onCompleted: flickableItem.interactive = Qt.binding(function() { return … }) since we override the interactive to workaround it also affecting keyboard input
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (line 50)
<https://git.reviewboard.kde.org/r/125908/#comment60249>
The ScrollArea clips its viewport on its own
- Kai Uwe Broulik
On Nov. 1, 2015, 2:06 nachm., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2015, 2:06 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
>
>
> Diffs
> -----
>
> applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7
>
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
>
>
> Testing
> -------
>
> Works fine. One thing that would be great is to allow vertical wheel scrolling, but for that KQuickControlsAddons.EventGenerator needs to support wheel events (custom wheel handling would be too complex for Flickable)
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151101/7036e200/attachment.html>
More information about the Plasma-devel
mailing list