Review Request 123946: Add api to disable plot grid lines

Marco Martin notmart at gmail.com
Sun May 31 12:37:48 UTC 2015



> On May 31, 2015, 7:20 a.m., David Edmundson wrote:
> > what doesn't work about
> > 
> > setHorizontalGridLineCount: 0 ?

becauseeeee, didn't tought about it :p
yup, horizontalGridLineCount: 0 is just fine ;)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123946/#review80990
-----------------------------------------------------------


On May 30, 2015, 6:54 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123946/
> -----------------------------------------------------------
> 
> (Updated May 30, 2015, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Thomas Pfeiffer.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> This is from feedback from the VDG: for the system monitor widget would be better to not have the horizontal grid lines for the plots as they don't add much information in this case and clutter the scene a bit.
> the system monitor applets would make use of this.
> 
> to maintain compatibility still draw the lines, but add api to disable them (since there already was api for the grid, it shouldn't be broken)
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 
>   src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 9a939c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123946/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150531/6b4a358e/attachment.html>


More information about the Plasma-devel mailing list